fix: type some issues in @asgardeo/javascript & @asgardeo/react packages
#226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request focuses on improving type safety and consistency across both the JavaScript and React packages. The main changes include stricter typing for component configs and models, updates to workflow files to support matrix-based pnpm versioning, and enhancements to SDK response types.
Type Safety and Model Improvements
packages/react/src/components/adapters/to use explicit type casting for config values, ensuring more reliable and predictable type usage throughout form field rendering. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]packages/javascript/src/models/to use more precise types (e.g., makingclientIdoptional, refiningconfigandtypefields, and extending the sign-in flow response structure). [1] [2] [3]SDK and API Enhancements
signInmethod inAsgardeoReactClientnow returns either aUseror the newEmbeddedSignInFlowResponseV2type, supporting richer SDK-level responses. [1] [2]Workflow and CI Improvements
.github/workflows/pr-builder.ymland.github/workflows/npm-audit.yml) to use a matrix forpnpm-version, improving flexibility and future-proofing CI for dependency management. [1] [2] [3] [4] [5] [6] [7]Release Documentation
@asgardeo/javascriptand@asgardeo/react, summarizing the type safety improvements.Related Issues
Related PRs
Checklist
Security checks